Get issue comments API didn't return review details

[NepPure]

• Gitea version (or commit ref):1.10.0
• Git version:
• Operating system:
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes https://try.gitea.io/api/v1/repos/oyyzowen/test2/issues/5/comments
  • No
  • Not relevant
• Log gist:

Description

Test PR https://try.gitea.io/oyyzowen/test2/pulls/5?lang=en-US

API:/repos/{owner}/{repo}/issues/{index}/comments don't work as expected.

Screenshots

[NepPure]

gitea/routers/api/v1/repo/issue_comment.go

Line 64 in 59fc29d

Type: models.CommentTypeComment,

Include CommentTypeCode, add a new API, or add a parameter for comment type filtering?
Which solution would be better?

[lunny]

Maybe github could give use some idea.

[NepPure]

https://developer.github.com/v3/pulls/comments/#list-comments-on-a-pull-request

Github has a separate set of APIs for pull request.
We can get review details from https://api.github.com/repos/go-gitea/gitea/pulls/9274/comments

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.