-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address minor portability issues #9414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
reviewed
Dec 18, 2019
zeripath
approved these changes
Dec 18, 2019
mrsdizzie
reviewed
Dec 18, 2019
Codecov Report
@@ Coverage Diff @@
## master #9414 +/- ##
==========================================
- Coverage 41.51% 41.48% -0.03%
==========================================
Files 569 569
Lines 74322 74322
==========================================
- Hits 30855 30835 -20
- Misses 39627 39646 +19
- Partials 3840 3841 +1
Continue to review full report at Codecov.
|
Some systems don't use GNU make by default, and use something like gnumake or gmake. Respect that when determining the make version.
mrsdizzie
approved these changes
Dec 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
topic/build
PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address some minor annoyances when building on FreeBSD (and possibly other systems):
Use $(MAKE) instead of "make" when determining the GNU Make version
Add OS specific sed for FreeBSD