Insufficent LDAP log

[finkr]

• Gitea version : 1.11

• Can you reproduce the bug at https://try.gitea.io:

  • Yes (provide example URL)
  • No
  • Not relevant

• Log gist:

  2019/12/20 18:46:51 ...es/auth/ldap/ldap.go:101:findUserDN() [D] Failed search using filter[(objectCategory=user)%!(EXTRA string=jdoe)]: LDAP Result Code 201 "Filter Compile Error": ldap: finished compiling filter with extra at end: %!(EXTRA string=jdoe)
  2019/12/20 18:46:51 ...dels/login_source.go:797:UserSignIn() [W] Failed to login 'jdoe' via 'MYDOMAIN': user does not exist [uid: 0, name: jdoe, keyid: 0]
  

Description

I had hard time to diagnose the issue an LDAP configuration error, because the LDAP error message aren't shown in the log in level "LEVEL=info". Actually there was no error message at all. I had to set "LEVEL=debug" in the file app.ini.

Could you add an entry in the log when there's an LDAP error.

It would be nice to include the LDAP error message in the log, or explain that one have to switch to LEVEL=debug to get the full error message.

I love Gitea, Thanks !

[eNBeWe]

Even tough it is not often that you need to tinker aroiudn with the ldap connections, I stumbled into some problem today. I would have expected to find some errors in my log when the request didn't go through.

[zeripath]

OK, So there are a few issues here.

Various different LDAP providers will return different errors when there is normal functioning - it's not a very well defined standard.

So... If you want this improved ... we're going to need to see what those errors are. For example What kind of error is returned with failure of SimpleBind? What kind of error is returned when a user can't be found?