Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor notificationsForUser since xorm In support slice of customer… #956

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Refactor notificationsForUser since xorm In support slice of customer… #956

merged 1 commit into from
Feb 16, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 16, 2017

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 16, 2017
@lunny lunny added this to the 1.1.0 milestone Feb 16, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 16, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 16, 2017
@lunny lunny merged commit 46320f9 into go-gitea:master Feb 16, 2017
@lunny lunny deleted the lunny/optimization_notificationsForUser branch February 16, 2017 04:07
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lunny @ethantkoenig @appleboy @tboerger