Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stray fmt.Printf in services/pull/patch.go #9631

Merged
merged 1 commit into from Jan 7, 2020
Merged

Remove stray fmt.Printf in services/pull/patch.go #9631

merged 1 commit into from Jan 7, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Jan 7, 2020

Unfortunately #9302 introduced a stray fmt.Printf(...) which should be removed.

@zeripath zeripath added this to the 1.11.0 milestone Jan 7, 2020
bagasme
bagasme reviewed Jan 7, 2020
View reviewed changes
Copy link
Contributor

@bagasme bagasme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one liner removal?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 7, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 7, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 7, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@c88f0fe). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9631   +/-   ##
=========================================
  Coverage          ?   42.21%           
=========================================
  Files             ?      582           
  Lines             ?    77104           
  Branches          ?        0           
=========================================
  Hits              ?    32552           
  Misses            ?    40553           
  Partials          ?     3999
Impacted Files Coverage Δ
services/pull/patch.go 62.65% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c88f0fe...f005e70. Read the comment docs.

@6543
Copy link
Member

6543 commented Jan 7, 2020

ready to merge 🚀 ;)

@zeripath zeripath merged commit 0d51547 into go-gitea:master Jan 7, 2020
@zeripath zeripath deleted the remove-stray-printf branch January 7, 2020 14:30
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagasme bagasme bagasme left review comments

@lunny lunny lunny approved these changes

@guillep2k guillep2k guillep2k approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@zeripath @codecov-io @6543 @lunny @guillep2k @bagasme @GiteaBot