Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pull request api convert to convert package #9664

Merged
merged 3 commits into from
Jan 10, 2020
Merged

Move pull request api convert to convert package #9664

merged 3 commits into from
Jan 10, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 9, 2020

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 9, 2020
@lunny lunny mentioned this pull request Jan 9, 2020
Merged
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 9, 2020
guillep2k
guillep2k approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one thing we should consider.

routers/api/v1/repo/pull.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 9, 2020
@codecov-io
Copy link

codecov-io commented Jan 10, 2020 •
edited

Codecov Report

Merging #9664 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9664      +/-   ##
==========================================
+ Coverage   42.24%   42.24%   +<.01%     
==========================================
  Files         588      588              
  Lines       77989    77991       +2     
==========================================
+ Hits        32947    32949       +2     
+ Misses      41000    40999       -1     
- Partials     4042     4043       +1
Impacted Files Coverage Δ
services/pull/check.go 55.4% <0%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70ccfa4...45fc88c. Read the comment docs.

@lunny lunny merged commit 384c2b3 into go-gitea:master Jan 10, 2020
@lunny lunny deleted the lunny/move_apiformat branch January 10, 2020 07:53
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lunny @codecov-io @guillep2k @6543 @GiteaBot