Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golangci-lint 1.22.2 #9711

Merged
merged 2 commits into from
Jan 11, 2020
Merged

golangci-lint 1.22.2 #9711

merged 2 commits into from
Jan 11, 2020

Conversation

techknowlogick
Copy link
Member

as title

@techknowlogick techknowlogick added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 11, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 11, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 11, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@f43a7c2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9711   +/-   ##
=========================================
  Coverage          ?   42.16%           
=========================================
  Files             ?      592           
  Lines             ?    78155           
  Branches          ?        0           
=========================================
  Hits              ?    32953           
  Misses            ?    41155           
  Partials          ?     4047
Impacted Files Coverage Δ
modules/queue/queue_wrapped.go 8.94% <ø> (ø)
modules/queue/queue_disk_channel.go 73.22% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f43a7c2...2746c3b. Read the comment docs.

@lafriks lafriks merged commit fef49f5 into go-gitea:master Jan 11, 2020
@techknowlogick techknowlogick deleted the techknowlogick-patch-3 branch January 12, 2020 02:39
sapk added a commit to sapk-fork/gitea that referenced this pull request Jan 13, 2020
@sapk
ci: go back to 1.20.0
a15294e 
Revert go-gitea#9711
This was referenced Jan 13, 2020
Closed
Merged
sapk added a commit that referenced this pull request Jan 13, 2020
@sapk
ci: go back to golangci-lint 1.20.0 (#9742)
dfe4564 
Revert #9711
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@techknowlogick @codecov-io @lafriks @6543 @GiteaBot