Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated targets from Makefile #9729

Merged
merged 3 commits into from
Jan 12, 2020
Merged

remove deprecated targets from Makefile #9729

merged 3 commits into from
Jan 12, 2020

Conversation

silverwind
Copy link
Member

  • remove deprecated targets
  • ensure 1 empty line between targets

silverwind
silverwind commented Jan 12, 2020
View reviewed changes
Makefile Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 12, 2020
@codecov-io
Copy link

codecov-io commented Jan 12, 2020 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@9744c77). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9729   +/-   ##
=========================================
  Coverage          ?   42.26%           
=========================================
  Files             ?      597           
  Lines             ?    78257           
  Branches          ?        0           
=========================================
  Hits              ?    33074           
  Misses            ?    41133           
  Partials          ?     4050

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9744c77...042875d. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 12, 2020
@silverwind silverwind changed the title clean up Makefile clean up Makefile, adjust 'clean' target Jan 12, 2020
@silverwind
Copy link
Member Author

silverwind commented Jan 12, 2020 •
edited

One more change:

  • make clean now cleans everything, introduced make clean-go to clean only the build and integration tests.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 12, 2020
@sapk sapk added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 12, 2020
6543
6543 reviewed Jan 12, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@lunny
Copy link
Member

lunny commented Jan 12, 2020

Maybe we should also update the documentation.

@silverwind
Copy link
Member Author

Reverted controversial clean change, should be good to go now.

@silverwind silverwind changed the title clean up Makefile, adjust 'clean' target clean up Makefile, remove deprecated targets Jan 12, 2020
@silverwind silverwind changed the title clean up Makefile, remove deprecated targets remove deprecated targets from Makefile Jan 12, 2020
@silverwind
remove deprecated targets from Makefile
3756451 
- remove deprecated targets
- ensure 1 empty line between targets
guillep2k
guillep2k reviewed Jan 12, 2020
View reviewed changes
Makefile
@@ -181,10 +181,6 @@ errcheck:
fi
errcheck $(PACKAGES)

.PHONY: lint
lint:
Copy link
Member

@guillep2k guillep2k Jan 12, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to make lint an alias of golangci-lint which I find too long to type.. 😏

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm thinking about re-adding lint but it would run the JS linter too 😉

@sapk sapk merged commit 74e35aa into go-gitea:master Jan 12, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k left review comments

@zeripath zeripath zeripath approved these changes

@sapk sapk sapk approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@silverwind @codecov-io @lunny @zeripath @sapk @guillep2k @6543 @GiteaBot