Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: go back to golangci-lint 1.20.0 #9742

Merged
merged 2 commits into from
Jan 13, 2020
Merged

Conversation

sapk
Copy link
Member

@sapk sapk commented Jan 13, 2020

Revert #9711

I don't really know if it will fix thing but worth a try. 馃槃

@codecov-io
Copy link

codecov-io commented Jan 13, 2020

Codecov Report

Merging #9742 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9742      +/-   ##
==========================================
+ Coverage   42.26%   42.27%   +0.01%     
==========================================
  Files         597      597              
  Lines       78257    78257              
==========================================
+ Hits        33074    33086      +12     
+ Misses      41133    41118      -15     
- Partials     4050     4053       +3
Impacted Files Coverage 螖
routers/repo/view.go 39.47% <0%> (+0.87%) 猬嗭笍
models/webhook.go 70.46% <0%> (+1.06%) 猬嗭笍
services/pull/check.go 55.4% <0%> (+2.02%) 猬嗭笍
models/unit.go 67.56% <0%> (+5.4%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a15294e...87994e6. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 13, 2020
@sapk
Copy link
Member Author

sapk commented Jan 13, 2020

I will retstart multiple time the job to find if it solved the problem.

@bagasme
Copy link
Contributor

bagasme commented Jan 13, 2020

@sapk what's wrong so that you did this?

@sapk
Copy link
Member Author

sapk commented Jan 13, 2020

@bagasme golangci-lint fail "randomly" on various test. ex: https://drone.gitea.io/go-gitea/gitea/19284/1/10

@sapk
Copy link
Member Author

sapk commented Jan 13, 2020

So far 3 builds without problem

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 13, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 13, 2020
@6543
Copy link
Member

6543 commented Jan 13, 2020

working CI is more important than a new version :)

@sapk sapk merged commit dfe4564 into go-gitea:master Jan 13, 2020
@sapk sapk deleted the ci-revert-to-1-20 branch January 13, 2020 14:06
@sapk
Copy link
Member Author

sapk commented Jan 13, 2020

Yes, I am pretty sure that golangci-lint maintainer will figure it out.

@sapk sapk added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 13, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants