Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor repository check and sync functions #9854

Merged
merged 6 commits into from
Jan 20, 2020
Merged

Refactor repository check and sync functions #9854

merged 6 commits into from
Jan 20, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 18, 2020

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 18, 2020
@codecov-io
Copy link

codecov-io commented Jan 18, 2020 •
edited
Loading

Codecov Report

Merging #9854 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9854      +/-   ##
=========================================
- Coverage    42.3%   42.3%   -0.01%     
=========================================
  Files         607     607              
  Lines       79353   79353              
=========================================
- Hits        33569   33568       -1     
- Misses      41642   41643       +1     
  Partials     4142    4142
Impacted Files Coverage Δ
services/pull/check.go 54.54% <0%> (-2.1%) ⬇️
services/pull/patch.go 67.92% <0%> (ø) ⬆️
models/repo.go 49.89% <0%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba3f3f4...b2b2f8d. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 18, 2020
@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 19, 2020
@lunny
Copy link
Member Author

lunny commented Jan 19, 2020

This also fixed a bug caused by added column OwnerName.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 19, 2020
zeripath
zeripath reviewed Jan 19, 2020
View reviewed changes
models/migrations/v36.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 20, 2020
@zeripath zeripath merged commit d92781b into go-gitea:master Jan 20, 2020
@lunny lunny deleted the lunny/refactor_tasks branch January 21, 2020 04:08
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath left review comments

@guillep2k guillep2k guillep2k approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lunny @codecov-io @zeripath @guillep2k @6543 @GiteaBot @sapk