Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hyphen in language name #9873

Merged
merged 2 commits into from
Jan 19, 2020

Conversation

zeripath
Copy link
Contributor

Highlight js has a language class jboss-cli that we will currently sanitize away.

We should allow hyphens in markdown code block names.

@zeripath zeripath added this to the 1.12.0 milestone Jan 19, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 19, 2020
@guillep2k
Copy link
Member

guillep2k commented Jan 19, 2020

How about digits?

EDIT: \w already includes digits. (word characters (≡ [0-9A-Za-z_]))

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 19, 2020
@codecov-io
Copy link

codecov-io commented Jan 19, 2020

Codecov Report

Merging #9873 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9873      +/-   ##
==========================================
- Coverage   42.32%   42.27%   -0.05%     
==========================================
  Files         604      604              
  Lines       79155    79228      +73     
==========================================
- Hits        33504    33496       -8     
- Misses      41523    41603      +80     
- Partials     4128     4129       +1
Impacted Files Coverage Δ
routers/user/auth.go 11.44% <0%> (-0.59%) ⬇️
modules/setting/setting.go 45.09% <0%> (-0.44%) ⬇️
modules/graceful/server.go 48.55% <0%> (-3.8%) ⬇️
services/pull/check.go 54.54% <0%> (-4.2%) ⬇️
modules/process/manager.go 74.69% <0%> (-3.62%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/error.go 30.76% <0%> (-0.55%) ⬇️
models/repo.go 47.02% <0%> (-0.13%) ⬇️
models/gpg_key.go 55.59% <0%> (+0.55%) ⬆️
services/pull/patch.go 67.92% <0%> (+1.25%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc7d24...4e4fba4. Read the comment docs.

@zeripath zeripath merged commit 948dec3 into go-gitea:master Jan 19, 2020
@zeripath zeripath deleted the fix-language-class-sanitiser branch January 19, 2020 21:36
zeripath added a commit to zeripath/gitea that referenced this pull request Jan 19, 2020
techknowlogick added a commit that referenced this pull request Jan 20, 2020
Co-authored-by: techknowlogick <matti@mdranta.net>
@zeripath zeripath added the backport/done All backports for this PR have been created label Jan 22, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants