Fix RocketChat webhook #9908
Merged
Fix RocketChat webhook #9908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <john.olheiser@gmail.com>
guillep2k
reviewed
Jan 21, 2020
GiteaBot
added
the
lgtm/need 2
Signed-off-by: jolheiser <john.olheiser@gmail.com>
|
If this bug was caused by #9378, perhaps we should consider backporting this fix into 1.10.4, as that PR was backported to 1.10.2. |
Codecov Report
@@ Coverage Diff @@
## master #9908 +/- ##
==========================================
+ Coverage 42.3% 42.31% +<.01%
==========================================
Files 607 607
Lines 79352 79352
==========================================
+ Hits 33571 33574 +3
+ Misses 41639 41636 -3
Partials 4142 4142
Continue to review full report at Codecov.
|
zeripath
approved these changes
Jan 21, 2020
GiteaBot
added
lgtm/need 1
6543
approved these changes
Jan 21, 2020
GiteaBot
added
lgtm/done
lafriks
approved these changes
Jan 21, 2020
|
@jolheiser Please, can you send backport if possible ? |
jolheiser
added a commit
to jolheiser/gitea
that referenced
this pull request
Jan 21, 2020
* Fix RocketChat?? Signed-off-by: jolheiser <john.olheiser@gmail.com> * Don't send attachment for repo create/delete Signed-off-by: jolheiser <john.olheiser@gmail.com> * Make fmt Signed-off-by: jolheiser <john.olheiser@gmail.com> Co-authored-by: Lauris BH <lauris@nix.lv>
|
This works like a charm on latest docker build! Thank you! |
techknowlogick
pushed a commit
that referenced
this pull request
Jan 21, 2020
* Fix RocketChat?? Signed-off-by: jolheiser <john.olheiser@gmail.com> * Don't send attachment for repo create/delete Signed-off-by: jolheiser <john.olheiser@gmail.com> * Make fmt Signed-off-by: jolheiser <john.olheiser@gmail.com> Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: Lauris BH <lauris@nix.lv>
techknowlogick
added
the
backport/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9899
I'm fairly certain this should fix rocket chat webhooks for push actions.I do not have a rocket chat instance to confirm on, however, so this PR should probably not be accepted until someone can confirm.Turns out rocket chat has a free cloud trial, so I can confirm it works.
I also just removed attachments altogether for repo create/delete event, as it was always blank. 🤷♂️
(Repo event) With blank attachment
(Repo event) Without
(Push event) Rocket Chat
(Repo events and push event) Slack
