Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create terminated channel in queue_redis #9910

Merged
merged 3 commits into from
Jan 21, 2020
Merged

Create terminated channel in queue_redis #9910

merged 3 commits into from
Jan 21, 2020

Conversation

zeripath
Copy link
Contributor

Fix #9909

@zeripath zeripath added this to the 1.12.0 milestone Jan 21, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 21, 2020
@codecov-io
Copy link

codecov-io commented Jan 21, 2020 •
edited
Loading

Codecov Report

Merging #9910 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9910      +/-   ##
==========================================
- Coverage    42.3%   42.29%   -0.01%     
==========================================
  Files         607      607              
  Lines       79354    79357       +3     
==========================================
- Hits        33567    33565       -2     
- Misses      41645    41651       +6     
+ Partials     4142     4141       -1
Impacted Files Coverage Δ
models/issue_comment_list.go 73.82% <0%> (-0.8%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
routers/repo/view.go 38.59% <0%> (-0.88%) ⬇️
services/pull/patch.go 69.81% <0%> (+3.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48af63a...5ea44e1. Read the comment docs.

@zeripath zeripath mentioned this pull request Jan 21, 2020
Merged
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 21, 2020
@zeripath zeripath merged commit 8cb9b2f into go-gitea:master Jan 21, 2020
@lunny lunny added the backport/done All backports for this PR have been created label Jan 21, 2020
@zeripath zeripath deleted the Create-terminated branch June 11, 2020 08:55
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Panic in RedisQueue on Terminate
5 participants
@zeripath @codecov-io @lunny @guillep2k @GiteaBot