Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regexp ranges #9977

Merged
merged 1 commit into from
Jan 25, 2020
Merged

Fix regexp ranges #9977

merged 1 commit into from
Jan 25, 2020

Conversation

guillep2k
Copy link
Member

This PR fixes the RegExp ranges.

Sorry about goofing up.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 25, 2020
@zeripath zeripath added modifies/translation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Jan 25, 2020
@zeripath zeripath added this to the 1.12.0 milestone Jan 25, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 25, 2020
@codecov-io
Copy link

Codecov Report

Merging #9977 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9977   +/-   ##
=======================================
  Coverage   42.27%   42.27%           
=======================================
  Files         610      610           
  Lines       80370    80370           
=======================================
  Hits        33973    33973           
- Misses      42213    42214    +1     
+ Partials     4184     4183    -1
Impacted Files Coverage Δ
models/unit.go 37.03% <0%> (-2.47%) ⬇️
services/pull/merge.go 51.36% <0%> (-0.69%) ⬇️
services/pull/patch.go 67.92% <0%> (+3.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb8f0c2...f990c89. Read the comment docs.

@6543
Copy link
Member

6543 commented Jan 25, 2020

ok lets make it fly ...

@zeripath zeripath merged commit 1b4357a into go-gitea:master Jan 25, 2020
@jolheiser jolheiser mentioned this pull request Jan 30, 2020
Closed
3 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@guillep2k @codecov-io @6543 @zeripath @GiteaBot