Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong paging on org members #9990

Merged
merged 1 commit into from
Jan 26, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 26, 2020

Fix #9989

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 26, 2020
@lunny lunny added this to the 1.12.0 milestone Jan 26, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 26, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 26, 2020
@codecov-io
Copy link

Codecov Report

Merging #9990 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9990      +/-   ##
==========================================
- Coverage   42.27%   42.25%   -0.02%     
==========================================
  Files         610      610              
  Lines       80370    80370              
==========================================
- Hits        33973    33964       -9     
- Misses      42218    42228      +10     
+ Partials     4179     4178       -1
Impacted Files Coverage Δ
models/list_options.go 57.89% <ø> (ø) ⬆️
routers/org/members.go 0% <0%> (ø) ⬆️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
services/pull/check.go 54.54% <0%> (-2.1%) ⬇️
routers/repo/view.go 38.59% <0%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59510d6...8bc3712. Read the comment docs.

@lunny lunny merged commit 8d51f28 into go-gitea:master Jan 26, 2020
@lunny lunny deleted the lunny/fix_org_members_page branch January 26, 2020 07:33
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Org members page 2 is empty
5 participants