New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some refactor on git diff and ignore getting commit information failed on migrating pull request review comments #9996
Some refactor on git diff and ignore getting commit information failed on migrating pull request review comments #9996
Conversation
eb58f8e
to
cf6a929
Compare
Codecov Report
@@ Coverage Diff @@
## master #9996 +/- ##
==========================================
+ Coverage 42.26% 42.26% +<.01%
==========================================
Files 611 611
Lines 80391 80391
==========================================
+ Hits 33976 33978 +2
+ Misses 42237 42235 -2
Partials 4178 4178
Continue to review full report at Codecov.
|
Beside modules/migrations/gitea.go it is a refactor |
@lunny it's hard to see what you've fixed and what's been moved - I wonder could you split the commits in two - one doing the move and one doing the fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of nits.
…d on migrating pull request review comments
cf6a929
to
733a395
Compare
When migrating a repository from github with pull requests, if the pull request review comments refs an outdate commit which is not yet on this repository any more. We should ignore that commits.
This pull request also moved some git diff functions from package
gitdiff
togit
.