Warning and Note issued on Linux #213

wdevore · 2018-01-19T18:51:45Z

Fyi,
go-gl built fine except a warning and note appeared, so I thought I would post it here:

go get -u github.com/go-gl/glfw/v3.2/glfw

_# github.com/go-gl/glfw/v3.2/glfw
In file included from src/github.com/go-gl/glfw/v3.2/glfw/c_glfw_linbsd.go:22:0:
src/github.com/go-gl/glfw/v3.2/glfw/glfw/src/linux_joystick.c: In function ‘_glfwInitJoysticksLinux’:
src/github.com/go-gl/glfw/v3.2/glfw/glfw/src/linux_joystick.c:224:42: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 9 [-Wformat-truncation=]

snprintf(path, sizeof(path), "%s/%s", dirname, entry->d_name);
^~~~~~~

In file included from /usr/include/stdio.h:862:0,
from /usr/include/X11/Xcursor/Xcursor.h:26,
from src/github.com/go-gl/glfw/v3.2/glfw/glfw/src/x11_platform.h:39,
from src/github.com/go-gl/glfw/v3.2/glfw/glfw/src/internal.h:169,
from src/github.com/go-gl/glfw/v3.2/glfw/glfw/src/x11_init.c:28,
from src/github.com/go-gl/glfw/v3.2/glfw/c_glfw_linbsd.go:17:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10: note: ‘__builtin___snprintf_chk’ output between 12 and 267 bytes into a destination of size 20
return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
              __bos (__s), __fmt, __va_arg_pack ());
              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

my go environment

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/xxx/Documents/Development/Go"
GORACE=""
GOROOT="/usr/local/bin/go"
GOTOOLDIR="/usr/local/bin/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build583228998=/tmp/go-build -gno-record-gcc-switches"
CXX="/usr/bin/clang++3.9"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

The text was updated successfully, but these errors were encountered:

elmindreda · 2018-01-20T17:14:36Z

This has since been fixed with glfw/glfw@5bcf9c7.

dmitshur · 2018-01-20T19:14:49Z

Thank you for confirming that @elmindreda.

We are already using the latest GLFW 3.2.1 version here. When the next version of GLFW containing the fix is released, we’ll update, and the warnings will disappear. They can be ignored until then.

So, there’s nothing to do in go-gl/glfw at this time.

dmitshur · 2018-08-21T04:27:22Z

Reopening for visibility (see #222 (comment)). /cc @capnm

Nothing to do here other than to eventually update to the next version of GLFW.

capnm · 2018-08-30T14:07:11Z

In go are the warnings very visible ;-)
I tried to locally cherry-pick the change but asprint is a GNU extension, maybe someone has a better idea?

diff --git a/go.mod b/go.mod
new file mode 100644
index 0000000..3e94336
--- /dev/null
+++ b/go.mod
@@ -0,0 +1 @@
+module github.com/go-gl/glfw
diff --git a/v3.2/glfw/glfw/src/linux_joystick.c b/v3.2/glfw/glfw/src/linux_joystick.c
index 561b1eb..53ffb1a 100644
--- a/v3.2/glfw/glfw/src/linux_joystick.c
+++ b/v3.2/glfw/glfw/src/linux_joystick.c
@@ -215,15 +215,24 @@ GLFWbool _glfwInitJoysticksLinux(void)
 
         while ((entry = readdir(dir)))
         {
-            char path[20];
             regmatch_t match;
+            char* path = NULL;
 
             if (regexec(&_glfw.linux_js.regex, entry->d_name, 1, &match, 0) != 0)
                 continue;
+#pragma GCC diagnostic ignored "-Wimplicit-function-declaration"
+            if (asprintf(&path, "%s/%s", dirname, entry->d_name) < 0)
+            {
+                _glfwInputError(GLFW_PLATFORM_ERROR,
+                                "Linux: Failed to construct device path: %s",
+                                strerror(errno));
+                continue;
+            }
 
-            snprintf(path, sizeof(path), "%s/%s", dirname, entry->d_name);
             if (openJoystickDevice(path))
                 count++;
+
+           free(path);
         }
 
         closedir(dir);

go.mod:

replace github.com/go-gl/glfw => ../glfw-wip

tapir · 2018-08-30T14:33:11Z

please see 3.3 branch, this should be fixed there

capnm · 2018-08-30T16:52:34Z

please see 3.3 branch, this should be fixed there

Unfortunately, the version from the v2 directory is pulled into my project by 3rd party packages and is still the same in the 3.3 branch :-(

glfw-wip = 845371b

go build
# github.com/go-gl/glfw/v3.2/glfw
In file included from ../../glfw-wip/v3.2/glfw/c_glfw_linbsd.go:24:0:
../../glfw-wip/v3.2/glfw/glfw/src/linux_joystick.c: In function ‘_glfwInitJoysticksLinux’:
../../glfw-wip/v3.2/glfw/glfw/src/linux_joystick.c:224:42: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 9 [-Wformat-truncation=]
             snprintf(path, sizeof(path), "%s/%s", dirname, entry->d_name);
                                          ^~~~~~~
In file included from /usr/include/stdio.h:862:0,
                 from /usr/include/X11/Xcursor/Xcursor.h:26,
                 from ../../glfw-wip/v3.2/glfw/glfw/src/x11_platform.h:39,
                 from ../../glfw-wip/v3.2/glfw/glfw/src/internal.h:169,
                 from ../../glfw-wip/v3.2/glfw/glfw/src/x11_init.c:28,
                 from ../../glfw-wip/v3.2/glfw/c_glfw_linbsd.go:19:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10: note: ‘__builtin___snprintf_chk’ output between 12 and 267 bytes into a destination of size 20
   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        __bos (__s), __fmt, __va_arg_pack ());
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

capnm · 2018-08-30T17:41:33Z

Ah build.go was missing -D_GNU_SOURCE.
For anyone interested this patch fixes the issue in v3.2:
glfw-issue.patch.txt

alexniver · 2019-01-07T14:57:29Z

share a way to fix this warning.

find your local file v3.2/glfw/glfw/src/linux_joystick.c , open it
change char path[20]; to char path[512];
then go get -u github.com/go-gl/glfw/v3.2/glfw

after that, I got no warning anymore

rootVIII · 2019-10-18T05:05:30Z

I can't tell if this has been fixed or not... but 18.04 Ubuntu as of 18OCT2019:
EDIT: Same thing on Kali Rolling 2019.3

james@rootVIII:~/Desktop$ go run test.go 
# fyne.io/fyne/vendor/github.com/go-gl/glfw/v3.2/glfw
In file included from ../go/src/fyne.io/fyne/vendor/github.com/go-gl/glfw/v3.2/glfw/c_glfw_linbsd.go:24:0:
../go/src/fyne.io/fyne/vendor/github.com/go-gl/glfw/v3.2/glfw/glfw/src/linux_joystick.c: In function ‘_glfwInitJoysticksLinux’:
../go/src/fyne.io/fyne/vendor/github.com/go-gl/glfw/v3.2/glfw/glfw/src/linux_joystick.c:224:42: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 9 [-Wformat-truncation=]
             snprintf(path, sizeof(path), "%s/%s", dirname, entry->d_name);
                                          ^~~~~~~
In file included from /usr/include/stdio.h:862:0,
                 from /usr/include/X11/Xcursor/Xcursor.h:26,
                 from ../go/src/fyne.io/fyne/vendor/github.com/go-gl/glfw/v3.2/glfw/glfw/src/x11_platform.h:39,
                 from ../go/src/fyne.io/fyne/vendor/github.com/go-gl/glfw/v3.2/glfw/glfw/src/internal.h:169,
                 from ../go/src/fyne.io/fyne/vendor/github.com/go-gl/glfw/v3.2/glfw/glfw/src/x11_init.c:28,
                 from ../go/src/fyne.io/fyne/vendor/github.com/go-gl/glfw/v3.2/glfw/c_glfw_linbsd.go:19:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10: note: ‘__builtin___snprintf_chk’ output between 12 and 267 bytes into a destination of size 20
   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        __bos (__s), __fmt, __va_arg_pack ());
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
^C

pwaller · 2019-11-24T21:23:50Z

Hi Everyone, Sorry about the annoying warning, which came from the underlying glfw sources. Please upgrade to v3.3 (merged today in #256), and if you encounter any errors there, let's get them fixed!

stopping it for now as I can't figure out how to disable the C compiler strict error checking. once a newer version go go-gl is released with latest glfw (see go-gl/glfw#213) we can give it another go. Signed-off-by: Matt Mulhern <mattmulhern01@gmail.com>

add go module

dmitshur closed this as completed Jan 20, 2018

icexin mentioned this issue Apr 6, 2018

Warning on github.com/go-gl/glfw/v3.2/glfw/glfw/src/linux_joystick.c:224:42 icexin/gocraft#5

Open

pwaller mentioned this issue Aug 20, 2018

Go 1.11rc1 / gcc 7.3.0 warning #222

Closed

dmitshur added the external label Aug 21, 2018

dmitshur reopened this Aug 21, 2018

Noofbiz mentioned this issue Oct 26, 2018

Warnings related to linux joystick C files when building? faiface/pixel#143

Closed

iegomez mentioned this issue Apr 3, 2019

Windows Platform iegomez/lds#2

Closed

MauriceGit mentioned this issue May 19, 2019

Build on Ubuntu 18.04 MauriceGit/Voronoi_Image_Manipulation#2

Closed

pwaller closed this as completed Nov 24, 2019

dev-abir mentioned this issue Apr 6, 2020

PIXEL fails compile faiface/pixel#169

Closed

tapir mentioned this issue Jan 1, 2021

v3.2/glfw: warnings during build #298

Closed

cullenr pushed a commit to cullenr/yanhg that referenced this issue Feb 19, 2024

update to glfw 3.3 to squash this error go-gl/glfw#213

32d4665

add go module

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Warning and Note issued on Linux #213

Warning and Note issued on Linux #213

wdevore commented Jan 19, 2018

elmindreda commented Jan 20, 2018

dmitshur commented Jan 20, 2018

dmitshur commented Aug 21, 2018

capnm commented Aug 30, 2018 •

edited

Loading

tapir commented Aug 30, 2018

capnm commented Aug 30, 2018

capnm commented Aug 30, 2018

alexniver commented Jan 7, 2019

rootVIII commented Oct 18, 2019 •

edited

Loading

pwaller commented Nov 24, 2019

Warning and Note issued on Linux #213

Warning and Note issued on Linux #213

Comments

wdevore commented Jan 19, 2018

my go environment

elmindreda commented Jan 20, 2018

dmitshur commented Jan 20, 2018

dmitshur commented Aug 21, 2018

capnm commented Aug 30, 2018 • edited Loading

tapir commented Aug 30, 2018

capnm commented Aug 30, 2018

capnm commented Aug 30, 2018

alexniver commented Jan 7, 2019

rootVIII commented Oct 18, 2019 • edited Loading

pwaller commented Nov 24, 2019

capnm commented Aug 30, 2018 •

edited

Loading

rootVIII commented Oct 18, 2019 •

edited

Loading