Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bazel build support #363

Closed
wants to merge 2 commits into from
Closed

Add Bazel build support #363

wants to merge 2 commits into from

Conversation

garymm
Copy link

@garymm garymm commented Aug 23, 2022

For v3.3, Linux-X11 and macOS.

@garymm
Add Bazel build support
0b4652f 
For v3.3, Linux-X11 and macOS.
@Jacalz
Copy link
Collaborator

Jacalz commented Sep 11, 2022

No offence, but all Go projects that I know of just build using the regular Go tooling. This seems to me like something that adds extra complexity each time we update GLFW. Do we really want to carry the burden of maintaining this?

@garymm
Copy link
Author

garymm commented Sep 12, 2022

No offense taken. My project uses Bazel, and I agree we're unusual.
Given that I did the work for my own project, I thought I'd share this in the hopes that it'd be useful to others.
I think it will only need to be updated when a source file is added or deleted from v3.3.
Up to you whether that is too much of a maintenance burden.

@garymm
Copy link
Author

garymm commented Oct 10, 2022

@Jacalz could you please either close this, merge it, or LMK what you'd like me to do to get this ready to be merged?

@garymm
Move bazel root to v3.3/glfw
307caea 
I'm hoping this makes it easier for gazelle to consume.

Also fix some build issue with #include resolution. I'm not sure how
this stopped working.
@Jacalz
Copy link
Collaborator

Jacalz commented Oct 11, 2022

I don't think it is up to me in the end. Better check with @dmitshur first

@garymm garymm closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@garymm @Jacalz