Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go style acronyms #77

Merged
merged 2 commits into from
Jul 14, 2014
Merged

Go style acronyms #77

merged 2 commits into from
Jul 14, 2014

Conversation

tapir
Copy link
Member

@tapir tapir commented Jul 14, 2014

Closes #74.

@tapir
Copy link
Member Author

tapir commented Jul 14, 2014

Please review and merge. Thanks.

@pwaller
Copy link
Member

pwaller commented Jul 14, 2014

LGTM, though I thought we were keeping the old constants? Maybe since we're making breaking changes anyway, it's okay.

@tapir
Copy link
Member Author

tapir commented Jul 14, 2014

In another thread you mentioned you were not aware of devel branch so I figured that's why you wanted to keep the old constants.

@pwaller
Copy link
Member

pwaller commented Jul 14, 2014

👍

@dmitshur
Copy link
Member

LGTM.

tapir added a commit that referenced this pull request Jul 14, 2014
@tapir
Merge pull request #77 from tapir/devel_glfw3.1
37eaaf4 
Go style acronyms
@tapir tapir merged commit 37eaaf4 into go-gl:devel_glfw3.1 Jul 14, 2014
@tapir tapir mentioned this pull request Jul 14, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tapir @pwaller @dmitshur