API changes and support for GLFW 3.1 features. #65
Conversation
The cgo to Go type conversion in `goDropCB` is unfinished and needs to be improved.
|
@shurcooL Looks good. Thanks for this. I think we can delete devel branch now. |
|
Great, I've deleted Really looking forward for 3.1 to come out so we can press that big green button and close 3 issues at once! :D |
|
Me too, |
|
Yeah, I'll try to see if I can lend a hand fixing open issues there, as @elmindreda has a lot of work cut out. |
|
70% now! |
Add glfwSetCharModsCallback() support.
changelog updated
Use more idiomatic style for comments, which includes a space after the //. See https://code.google.com/p/go-wiki/wiki/CodeReviewComments#Comment_Senten ces. Remove references to LockOSThread Wiki example; simply mention runtime.LockOSThread() in README instead. Other than docs, there are no code or behavior changes.
Fix missing runtime.LockOSThread() in example code.
Improve documentation style slightly.
3.1 clean errors
The descriptions are taken from http://www.glfw.org/docs/latest/window.html. Add missing period at end of sentence for consistency.
Adhere strictly to C API naming
Implement rest of the 3.1 features
Standard cursor
|
I'm beginning work on #118: until I have a PR in for that please don't work on anything except the README to avoid collision as that change will likely touch every |
For details about this solution see the documentation for acceptError, panicError, and issue #118.
README overhaul
Return less errors; Fixes #118
This allows for the explicitly choosing to use the OpenGL ES 2 client instead of the standard OpenGL client on Desktop (386, amd64) platforms. To explicitly choose the OpenGL ES 2 client, use the build tag "gles2".
|
I've finally updated all my code to the latest commit on this branch, including API changes. It was definitely a win and made my user code simpler/shorter by removing At this time, I did not run into any instances where the removed error from API presented a problem. Thanks a lot to @slimsag for doing that PR #121! I'll keep testing it over the next few days and report any issues I notice. |
Allow use of OpenGL ES 2 on Desktop platforms with -tags=gles2
|
Sorry to bother you but is this ready to be merged yet or is there still some work to do? (Just asking because I am using a glfw version with a manually patched v3.1 feature in a personal project for half a year and I would love to switch to the official package) |
|
@mbertschler should be any day now. one issue left to resolve #123 |
|
@tapir Thank you! |
This PR contains changes from the
develbranch. That includes minor API changes that make the API easier to use and more idiomatic, as well as support for new features of GLFW 3.1. See changelog in README for a complete list of changes.It is planned to be merged into master when GLFW 3.1 is released.
Closes #40.
Closes #8.
Closes #56.
Closes #106.