Use endpoint from keystone in cinder client #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes LP:1512399, "Get https:... local error: record overflow". Previously the autogenerated code was inventing URLs to match a particular form, then updating just the host to match the real endpoint. This is insufficient if either the scheme is not https or if there are other leading path components. The autogenerated client code has already been manually edited, this change drops the pretense we can regenerate it, the master copy of the WADL files no longer works. There are some minor api changes here, the signature of NewClient has been changed, but the Basic entry point used by the openstack provider in juju is untouched. Also, the use of v2 paths is no longer enforced by the code through simply ignoring the keystone return values. Callers must verify the endpoint they are using is v2 if they require v2 functionality.
| // This file is not intended to be updated by hand, rather it should | ||
| // be regenerated every time this library is built. The WADLs were | ||
| // originally sourced from: | ||
| // This file was initially autogenerated from the upstream wadl file, but has |
There was a problem hiding this comment.
This makes me sad, but the WADL format really isn't complete enough to auto-generate everything anyway. Pity.
|
LGTM |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-goose |
jujubot
added a commit
that referenced
this pull request
Nov 13, 2015
Use endpoint from keystone in cinder client Fixes LP:1512399, "Get https:... local error: record overflow". Previously the autogenerated code was inventing URLs to match a particular form, then updating just the host to match the real endpoint. This is insufficient if either the scheme is not https or if there are other leading path components. The autogenerated client code has already been manually edited, this change drops the pretense we can regenerate it, the master copy of the WADL files no longer works. There are some minor api changes here, the signature of NewClient has been changed, but the Basic entry point used by the openstack provider in juju is untouched. Also, the use of v2 paths is no longer enforced by the code through simply ignoring the keystone return values. Callers must verify the endpoint they are using is v2 if they require v2 functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LP:1512399, "Get https:... local error: record overflow".
Previously the autogenerated code was inventing URLs to match a
particular form, then updating just the host to match the real
endpoint. This is insufficient if either the scheme is not https
or if there are other leading path components.
The autogenerated client code has already been manually edited,
this change drops the pretense we can regenerate it, the master
copy of the WADL files no longer works.
There are some minor api changes here, the signature of NewClient
has been changed, but the Basic entry point used by the openstack
provider in juju is untouched. Also, the use of v2 paths is no
longer enforced by the code through simply ignoring the keystone
return values. Callers must verify the endpoint they are using
is v2 if they require v2 functionality.