add cinder. BasicTLSConfig() #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manadart
approved these changes
Jul 31, 2018
jujubot
added a commit
to juju/juju
that referenced
this pull request
Aug 1, 2018
#8987 ## Description of change Make use of the cinder client change to allow for tls.Config data to be used when making api calls to an OpenStack requiring CACert as part of authentication. This pr requires a change to the goose libraries: go-goose/goose#65 . dependencies.tsv will be updated once it's landed. ## QA steps Using an openstack deployment requiring a CACert for access: 1. Add the ca cert to the clouds.yaml for the new cloud: clouds: openstack: type: openstack ..... ca-certificates: | -----BEGIN CERTIFICATE----- ..... -----END CERTIFICATE----- 1. juju bootstrap 2. use juju storage functionality. 3. juju destroy-controller should not fail with unable to list volumes. There should be no change with an openstack deployment not requiring a CACert. ## Documentation changes Not yet, one more item to be fixed. ## Bug reference https://bugs.launchpad.net/juju/+bug/1784030
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for a tls.Config to be passed for using a CACert with api calls to the OpenStack by adding cinder. BasicTLSConfig(). Related to: https://bugs.launchpad.net/juju/+bug/1784030
This has been tested by hand, and the current tests, with --live, to verify nothing currently working has been broken have been run. There is no cinder test service to run against for local tests. The fix involves returning a routine to be called, so verification of that is difficult. There is a long term plan to resolve some of these issues, in the mean time, please use with caution.