Add project domain id to identity credentials #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openrc downloaded from OpenStack horizon for a non-admin user has OS_PROJECT_DOMAIN_ID set but not OS_PROJECT_DOMAIN_NAME. Project domain ID details are added in Credentials structure. Fixes: go-goose#88
hemanthnakkina-zz
force-pushed
the
issue88
branch
from
9abd851
to
506b782
Compare
hemanthnakkina-zz
pushed a commit
to hemanthnakkina-zz/juju
that referenced
this pull request
Mar 31, 2021
juju autoload-credentials ignores the OS_PROJECT_DOMAIN_ID if set and looks for only OS_PROJECT_DOMAIN_NAME. However there are cases where openrc downloaded from OpenStack Dashboard for non-admin user sets only OS_PROJECT_DOMAIN_ID. In these cases juju bootstrap fails with authentication error since juju is not aware of project domain id and project domain name is empty. This change reads OS_PROJECT_DOMAIN_ID and sets in CredentialsAttribute map. The same have been passed to the client for authentication purpose. - This PR depends on PR submitted for go-goose package go-goose/goose#89 https://bugs.launchpad.net/juju/+bug/1772649
hemanthnakkina-zz
pushed a commit
to hemanthnakkina-zz/juju
that referenced
this pull request
Mar 31, 2021
juju autoload-credentials ignores the OS_PROJECT_DOMAIN_ID if set and looks for only OS_PROJECT_DOMAIN_NAME. However there are cases where openrc downloaded from OpenStack Dashboard for non-admin user sets only OS_PROJECT_DOMAIN_ID. In these cases juju bootstrap fails with authentication error since juju is not aware of project domain id and project domain name is empty. This change reads OS_PROJECT_DOMAIN_ID and sets in CredentialsAttribute map. The same have been passed to the client for authentication purpose. - This PR depends on PR submitted for go-goose package go-goose/goose#89 https://bugs.launchpad.net/juju/+bug/1772649 Fixes: LP#1772649
hemanthnakkina-zz
pushed a commit
to hemanthnakkina-zz/juju
that referenced
this pull request
Apr 5, 2021
juju autoload-credentials ignores the OS_PROJECT_DOMAIN_ID if set and looks for only OS_PROJECT_DOMAIN_NAME. However there are cases where openrc downloaded from OpenStack Dashboard for non-admin user sets only OS_PROJECT_DOMAIN_ID. In these cases juju bootstrap fails with authentication error since juju is not aware of project domain id and project domain name is empty. This change reads OS_PROJECT_DOMAIN_ID and sets in CredentialsAttribute map. The same have been passed to the client for authentication purpose. - This PR depends on PR submitted for go-goose package go-goose/goose#89 https://bugs.launchpad.net/juju/+bug/1772649 Fixes: LP#1772649
|
@hemanthnakkina, this looks good, I'm waiting on the using pr, before approving it. autoload-credentials wasn't doing what the QA steps said it should be. |
Hi I believe you are referring to QA steps in juju/juju#12838. I am on vacation and will be back on Apr 14th, can provide the exact steps with the output. |
|
@hmlanigan @hemanthnakkina is this close to merging? |
|
Closing as it's stale now, please reopen when the juju issues have been addressed in the related PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openrc downloaded from OpenStack horizon for a non-admin
user has OS_PROJECT_DOMAIN_ID set but not OS_PROJECT_DOMAIN_NAME.
Project domain ID details are added in Credentials structure.
Fixes: #88