Added missing white space #4330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR, I think maybe better to add a space before the |
|
I thought it would be better for consistency reasons. As all other checks adds a space at the end. |
Other places add a space at the end because there are always something after it, but not sure for this one. |
|
Ok I update so the space is added before the where clause. |
jinzhu
reviewed
Apr 28, 2021
MittWillson
pushed a commit
to itering/gorm
that referenced
this pull request
Sep 27, 2021
* Added missing white space * Added missing white space * Added missing white space
cgxxv
pushed a commit
to cgxxv/gorm
that referenced
this pull request
Mar 25, 2022
* Added missing white space * Added missing white space * Added missing white space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Added some missing spaces.
User Case Description
When using
clause.OnConflictwithDoUpdatesa white space was missing.