fix: save with hook (#6285)

[black-06]

• Do only one thing
• Non breaking API changes
• Tested

What did this pull request do?

Hook is executed twice in Save func, close #6285

User Case Description

type Token struct {
	ID  int
	Content string `gorm:"type:varchar(100)"`
}

func (t *Token) BeforeSave(tx *gorm.DB) error {
	t.Content += "_encrypted"
	return nil
}

token := Token{Content: "token"}
DB.Save(&token) // "token_encrypted"

token = Token{
	ID:           token.ID,
	Content: "token"
}
DB.Save(&token) // mysql RowsAffected is 0, it should be "token_encrypted" instead of "token_encrypted_encrypted"

[a631807682]

Does this mean that AfterSave has been executed during Update even if it is not updated the record (in this case AfterSave becomes BeforeSave)

[black-06]

Does this mean that AfterSave has been executed during Update even if it is not updated the record (in this case AfterSave becomes BeforeSave)

Yes.

[a631807682]

I seem to have other problems here, such as Create will not be executed when using Select, is Update necessary when we use OnConflict?
Of course, it's usually necessary to use Update and Create to avoid OnConflict, but if still need to use Create and OnConflict after Update, I'm not sure it's necessary.

[black-06]

I seem to have other problems here, such as Create will not be executed when using Select, is Update necessary when we use OnConflict? Of course, it's usually necessary to use Update and Create to avoid OnConflict, but if still need to use Create and OnConflict after Update, I'm not sure it's necessary.

Yes, it is necessary. OnConflict is added at #6149 .

For example, token in database (MySQL):

id	content
1	str

UPDATE `token` SET `content`='str' WHERE `id` = 1
-- rows: 0 (other db RowsAffected is 1)
-- Save will exec Create
-- Error 1062 (23000): Duplicate entry '1' for key 'token_owners.PRIMARY'

---

And this pr adds SkipHooks: true

[a631807682]

I seem to have other problems here, such as Create will not be executed when using Select, is Update necessary when we use OnConflict? Of course, it's usually necessary to use Update and Create to avoid OnConflict, but if still need to use Create and OnConflict after Update, I'm not sure it's necessary.

Yes, it is necessary. OnConflict is added at #6149 .

For example, token in database (MySQL):

id content
1 str

UPDATE `token` SET `content`='str' WHERE `id` = 1
-- rows: 0 (other db RowsAffected is 1)
-- Save will exec Create
-- Error 1062 (23000): Duplicate entry '1' for key 'token_owners.PRIMARY'

And this pr adds SkipHooks: true

My question is not whether OnConflict is necessary, but whether Update is necessary

[black-06]

I seem to have other problems here, such as Create will not be executed when using Select, is Update necessary when we use OnConflict? Of course, it's usually necessary to use Update and Create to avoid OnConflict, but if still need to use Create and OnConflict after Update, I'm not sure it's necessary.

Yes, it is necessary. OnConflict is added at #6149 .

For example, token in database (MySQL):

id content
1 str

UPDATE `token` SET `content`='str' WHERE `id` = 1
-- rows: 0 (other db RowsAffected is 1)
-- Save will exec Create
-- Error 1062 (23000): Duplicate entry '1' for key 'token_owners.PRIMARY'

And this pr adds SkipHooks: true

My question is not whether OnConflict is necessary, but whether Update is necessary

I have tried to create directly without update, but many tests have failed.
I guess it's related to perm and OnConflict will ignore them

[a631807682]

I see, thank you.