Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: coverage for foreign key violation err #6403

Merged
merged 5 commits into from
Jul 12, 2023

Conversation

saeidee
Copy link
Member

@saeidee saeidee commented Jun 11, 2023

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

Test coverage for ErrForeignKeyViolated, related issue: #6345

@saeidee saeidee self-assigned this Jun 11, 2023
@saeidee
Copy link
Member Author

saeidee commented Jun 11, 2023

Currently, MySQL PR is not merged go-gorm/mysql#122, and it is not implemented for sqlserver; I will do the PR for sqlserver.

@saeidee saeidee force-pushed the test-coverage-for-foreign-key-violated branch from eb389b1 to e550ed7 Compare June 11, 2023 19:25
@saeidee saeidee requested a review from a631807682 June 11, 2023 19:34
Copy link
Member

@a631807682 a631807682 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other problems, waiting for sqlserver to implement.

@saeidee saeidee force-pushed the test-coverage-for-foreign-key-violated branch from f6db161 to adcbf9f Compare June 13, 2023 07:25
@saeidee
Copy link
Member Author

saeidee commented Jun 13, 2023

Mysql driver giving some errors, I will fix that.

@saeidee saeidee force-pushed the test-coverage-for-foreign-key-violated branch 2 times, most recently from 07b9fff to d97d475 Compare June 16, 2023 07:22
@saeidee saeidee force-pushed the test-coverage-for-foreign-key-violated branch from d97d475 to 66f2153 Compare June 16, 2023 07:58
@saeidee saeidee force-pushed the test-coverage-for-foreign-key-violated branch from 66f2153 to 7d552a2 Compare June 16, 2023 08:08
@jinzhu jinzhu merged commit c10f807 into go-gorm:master Jul 12, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants