Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded OTEL libraries and examples #11

Merged
merged 5 commits into from
Jun 1, 2023
Merged

Conversation

Ahbrown41
Copy link
Contributor

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

  • Upgraded all libraries
  • Upgrade examples to Go 1.20
  • Fixed OTEL issues with newest OTEL libraries
  • Executed examples

User Case Description

  • Allowing it to work with other OTEL changes

@zstone12
Copy link
Collaborator

@Ahbrown41 Thanks fou you Code.Can you help to fix the CI?

@Ahbrown41
Copy link
Contributor Author

@Ahbrown41 Thanks fou you Code.Can you help to fix the CI?

So I am not as used to Github Actions but when I run these commands it works fine but in Github Actions appears to fail:

go vet -stdmethods=false $(go list ./...)
  go vet -stdmethods=false $(go list ./...)
  go install mvdan.cc/gofumpt@v0.5.0
  test -z "$(gofumpt -l -extra .)"

Have you seen this before or do you see an actual error that I have not been able to see so far?

@zstone12
Copy link
Collaborator

@Ahbrown41 Thanks fou you Code.Can you help to fix the CI?

So I am not as used to Github Actions but when I run these commands it works fine but in Github Actions appears to fail:

go vet -stdmethods=false $(go list ./...)
  go vet -stdmethods=false $(go list ./...)
  go install mvdan.cc/gofumpt@v0.5.0
  test -z "$(gofumpt -l -extra .)"

Have you seen this before or do you see an actual error that I have not been able to see so far?

I will check it later.

@zstone12
Copy link
Collaborator

zstone12 commented Jun 1, 2023

@Ahbrown41 It was just a simple formatting issue, so I went ahead and fixed it directly on your branch. Thanks for your PR:D.

@zstone12 zstone12 merged commit 2a6e1e2 into go-gorm:master Jun 1, 2023
2 checks passed
@DavidS-ovm
Copy link

Can we please get a release of this? Without users of this are stranded on outdated otel versions.

@DavidS-ovm
Copy link

Brilliant, thank you!! 💟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants