Use pre-Explain SQL for WithoutQueryVariables
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of `WithoutQueryVariables` substitutes `?` for any query variables and calls `tx.Dialector.Explain`, which can result in a lot of string allocations. This implementation avoids the substitution and uses whatever the default representation of the query parameters is for the SQL dialect.
|
Looks good to me. |
zstone12
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
The current implementation of
WithoutQueryVariablessubstitutes?for any query variables and callstx.Dialector.Explain, which can result in a lot of string allocations. This implementation avoids the substitution and uses whatever the default representation of the query parameters is for the SQL dialect.Fixes #14
User Case Description
We had performance issues with the previous implementation of tracing with the
WithoutQueryVariablesoption.