Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support customized tracer #2

Merged
merged 1 commit into from
Feb 20, 2021
Merged

feat: support customized tracer #2

merged 1 commit into from
Feb 20, 2021

Conversation

yeqown
Copy link
Collaborator

@yeqown yeqown commented Feb 20, 2021

  • Do only one thing
  • Nonbreaking API changes
  • Tested

What did this pull request do?

  • provide the WithTracer API to customize tracer
  • use opt options instead of logResult and tracer property in opentracingPlugin
  • define extractAfter and injectBefore into opentracingPlugin methods, and rename helper.go as opentracing_helper.go

User Case Description

use customized tracer of DB operation rather than have to use global tracer.

@yeqown
Copy link
Collaborator Author

yeqown commented Feb 20, 2021

#1

@yeqown yeqown requested a review from jinzhu February 20, 2021 08:17
@jinzhu jinzhu merged commit f29f76e into main Feb 20, 2021
@jinzhu jinzhu deleted the feature/with-tracer-option branch February 20, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinzhu jinzhu Awaiting requested review from jinzhu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeqown @jinzhu