Validating the migration ID exist in the list of migrations #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…migration before attempting to migrate
There was a problem hiding this comment.
Hi @tonytanger, thanks for reporting the issue and opening this PR.
Can you please add a test case to check it returns this error if an inexistent migration ID is given?
gormigrate.go
Outdated
| @@ -164,6 +172,18 @@ func (g *Gormigrate) checkDuplicatedID() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (g *Gormigrate) checkIDExist(migrationID string) error { | |||
| if migrationID == "" { | |||
There was a problem hiding this comment.
Hmm... maybe we should remove this if and just return the error if migrationID is ""?
I don't think rollbackTo should rollback all migration in any circumstance.
There was a problem hiding this comment.
I removed the check to allow empty migration ID. This also meant changes to Migrate so it doesn't migrate to an empty string, but to the last migration in the list, which I think is same semantics as before.
|
@tonytanger Seems great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return an error if the migration id passed that
MigrateToandRollbackTodoes not exist in the list of migrations.#20