Fixed NullTime returns always invalid on sqlite3. #203

umisama · 2014-10-17T08:54:01Z

gorp.NullTime is always return invalid if using sqlite3.

example:

type Test struct {
        Id    int           `db:"id"`
        Test  gorp.NullTime `db:"test"`
        TestA time.Time     `db:"test2"`
}

_, err = dbmap.Select(&list, `select * from TEST where id=?`, id)
if err != nil {
        panic(err)
for _, v := range list {
}

// always output false
fmt.Println(v.Test.Valid)

I fixed this probrem with handling []byte in NullTime.Scan(). And, I added tests for NullTime to find environment probrems.

thank you!

…hen a field marked transient matches a column mapped to another field. Fixes go-gorp#175 but reverses go-gorp#146 TestSelectAlias: modify to demonstrate how this behavior can be achieved using two separate structs - one that reflects the actual table structure (for inserts/updates) and one with the extended field, which can be used for selects.

Adding a table from a struct containing a member with name "Version" and type other than int results in a panic: 2015/01/27 15:42:57 http: panic serving 127.0.0.1:60027: reflect: call of reflect.Value.Int on string Value goroutine 23 [running]: net/http.func·011() c:/go/src/pkg/net/http/server.go:1100 +0xbe runtime.panic(0x7059e0, 0xc082007420) c:/go/src/pkg/runtime/panic.c:248 +0x1d3 reflect.Value.Int(0x697be0, 0xc082016ca0, 0x0, 0x186, 0x77e3d0) c:/go/src/pkg/reflect/value.go:1053 +0xc3 github.com/coopernurse/gorp.bindPlan.createBindInstance(0xc08205ef00, 0x162, 0xc08201e400, 0x12, 0x20, 0x0, 0x0, 0x0, 0x77e3d0, 0x7, ...) C:/Users/Christian/Google Drive/Development/go/src/github.com/coopernurse/gorp/gorp.go:289 +0x177 github.com/coopernurse/gorp.(*TableMap).bindInsert(0xc082020b40, 0x761280, 0xc082016c60, 0x0, 0x196, 0x0, 0x0, 0x0, 0x0, 0x0, ...) C:/Users/Christian/Google Drive/Development/go/src/github.com/coopernurse/gorp/gorp.go:394 +0x6e0 github.com/coopernurse/gorp.insert(0xc0820104e0, 0x181da0, 0xc0820104e0, 0x3a3a38, 0x1, 0x1, 0x0, 0x0) C:/Users/Christian/Google Drive/Development/go/src/github.com/coopernurse/gorp/gorp.go:1913 +0x2dc github.com/coopernurse/gorp.(*DbMap).Insert(0xc0820104e0, 0x3a3a38, 0x1, 0x1, 0x0, 0x0) C:/Users/Christian/Google Drive/Development/go/src/github.com/coopernurse/gorp/gorp.go:955 +0x97 From my POV, this is convention over configuration, just the wrong way around. My proposed solution is to disable setting the version ColMap in AddTable(i interface{}), forcing the developer to manually set the version column name by using SetVersionCol(). This is a crude fix, but it shows the problem and how to solve it.

Fixed tests by using SetVersionCol on person tablemap

Merge patch

benprew · 2015-01-31T19:02:04Z

@umisama Can you fix failing tests for this pull request?

https://travis-ci.org/go-gorp/gorp/jobs/38387723

--- FAIL: TestNullTime (0.01 seconds)
gorp_test.go:1413: NullTime returns invalid but expected valid.
gorp_test.go:1416: expect %v but got %v. 0000-01-02 15:04:05 +0000 UTC 0001-01-01 00:00:00 +0000 UTC

irc channel to Help/Support section

Remove maintainers notice (since PR is closed). Add Help/Support section

Also made the markdown headings consistently use prefixed #'s, no suffix.

Add gopkg.in versioned releases information.

Added warning telling users that automatic mapping of Version struct members to version column in database (optimistic locking) will be removed in V2

Changed log output to stderr

Fixed race condition

…ameters.

…into billmccord-194-named-params

GeertJohan · 2015-02-16T15:07:54Z

@umisama Please fix the failing tests and rebase this PR on the master branch (we've deprecated develop, sorry).

Fix old description about GORP_TEST_DIALECT in README.md

Fix expand query on NullTime or other structs.

Supported go versions

Adding a table from a struct containing a member with name "Version" and type other than int results in a panic: 2015/01/27 15:42:57 http: panic serving 127.0.0.1:60027: reflect: call of reflect.Value.Int on string Value goroutine 23 [running]: net/http.func·011() c:/go/src/pkg/net/http/server.go:1100 +0xbe runtime.panic(0x7059e0, 0xc082007420) c:/go/src/pkg/runtime/panic.c:248 +0x1d3 reflect.Value.Int(0x697be0, 0xc082016ca0, 0x0, 0x186, 0x77e3d0) c:/go/src/pkg/reflect/value.go:1053 +0xc3 github.com/coopernurse/gorp.bindPlan.createBindInstance(0xc08205ef00, 0x162, 0xc08201e400, 0x12, 0x20, 0x0, 0x0, 0x0, 0x77e3d0, 0x7, ...) C:/Users/Christian/Google Drive/Development/go/src/github.com/coopernurse/gorp/gorp.go:289 +0x177 github.com/coopernurse/gorp.(*TableMap).bindInsert(0xc082020b40, 0x761280, 0xc082016c60, 0x0, 0x196, 0x0, 0x0, 0x0, 0x0, 0x0, ...) C:/Users/Christian/Google Drive/Development/go/src/github.com/coopernurse/gorp/gorp.go:394 +0x6e0 github.com/coopernurse/gorp.insert(0xc0820104e0, 0x181da0, 0xc0820104e0, 0x3a3a38, 0x1, 0x1, 0x0, 0x0) C:/Users/Christian/Google Drive/Development/go/src/github.com/coopernurse/gorp/gorp.go:1913 +0x2dc github.com/coopernurse/gorp.(*DbMap).Insert(0xc0820104e0, 0x3a3a38, 0x1, 0x1, 0x0, 0x0) C:/Users/Christian/Google Drive/Development/go/src/github.com/coopernurse/gorp/gorp.go:955 +0x97 From my POV, this is convention over configuration, just the wrong way around. My proposed solution is to disable setting the version ColMap in AddTable(i interface{}), forcing the developer to manually set the version column name by using SetVersionCol(). This is a crude fix, but it shows the problem and how to solve it. Update gorp_test.go Fixed tests by using SetVersionCol on person tablemap Remove maintainers notice (since PR is closed). Add google group and irc channel to Help/Support section Use #gorp as channel Add gopkg.in versioned releases information. Also made the markdown headings consistently use prefixed #'s, no suffix. Change coopernurse/gorp to go-gorp/gorp in Makefile, godoc and comments. Extended the Exec functionality so that it can be used with named parameters. Unexport the Executor Removed version column detection in readStructColumns Update gorp.go Added warning telling users that automatic mapping of Version struct members to version column in database (optimistic locking) will be removed in V2 Update gorp.go Changed log output to stderr Added migration guide and notes Added migration guide and notes about change in behaviour in Optimistic locking. Update README.md Update gorp.go Corrected vim gone wild

Conflicts: .travis.yml

Readme: latest > last, minor > major. Removed unnecessary imports Removed unnecessary tests

Conflicts: .travis.yml

Remove automatic mapping of version column (optimistic locking)

umisama · 2015-02-27T05:31:16Z

Finally, test passed! (without go1.1)

GeertJohan · 2015-03-01T16:39:07Z

Great, thanks!

Fixed NullTime returns always invalid on sqlite3.

umisama · 2015-03-02T01:56:55Z

Sorry, you've merged to develop but it is must merged to master isn't it?

GeertJohan · 2015-03-02T12:21:16Z

Oh, yes you're right! I forgot to check if the PR was aimed at master..
Could you maybe rebase this on master and open a new PR?

umisama · 2015-03-03T15:38:49Z

Sorry, I had been misunderstanding about PR system. I create new PR. (see #237)

coveralls · 2016-10-04T15:49:00Z

Changes Unknown when pulling d376e08 on umisama:develop-patch1 into * on go-gorp:develop*.

coopernurse and others added 15 commits November 18, 2013 17:31

Merge branch 'release/v1.2.1'

32a45d9

Merge branch 'release/v1.3'

d2579dd

Update docs for SelectOne to reflect the code.

176b9dd

Merge branch 'release/v1.4'

08e1d8c

Merge branch 'release/v1.5'

242be3e

Merge branch 'release/v1.6'

c7d1aec

Merge branch 'release/v1.7'

5d19ebd

go-gorp#211 - add call for maintainers to README

236e138

Update README.md with new repo path.

3643e90

Merge branch 'develop'

1927cbe

Merge branch 'develop'

0a7ddd4

Update gorp_test.go

b943032

Fixed tests by using SetVersionCol on person tablemap

Merge pull request go-gorp#1 from sqdk/patch-1

305390f

Merge patch

benprew and others added 13 commits January 31, 2015 18:14

Remove maintainers notice (since PR is closed). Add google group and

c9804f2

irc channel to Help/Support section

Use #gorp as channel

e21f5e4

Merge pull request go-gorp#216 from go-gorp/update-readme

013813e

Remove maintainers notice (since PR is closed). Add Help/Support section

Add gopkg.in versioned releases information.

8387985

Also made the markdown headings consistently use prefixed #'s, no suffix.

Merge pull request go-gorp#217 from go-gorp/gopkg-in-releases

bb0da2f

Add gopkg.in versioned releases information.

Change coopernurse/gorp to go-gorp/gorp in Makefile, godoc and comments.

0160e43

Update gorp.go

188d84c

Added warning telling users that automatic mapping of Version struct members to version column in database (optimistic locking) will be removed in V2

Update gorp.go

0b23b74

Changed log output to stderr

Update gorp.go

c5d4bb0

Fixed race condition

Extended the Exec functionality so that it can be used with named par…

6356ca9

…ameters.

Unexport the Executor

db61a53

Merge branch '194-named-params' of https://github.com/billmccord/gorp …

5f5df32

…into billmccord-194-named-params

Merge branch 'billmccord-194-named-params'

f7757e0

umisama and others added 20 commits February 19, 2015 02:36

Fix expand query on NullTime or other structs.

78306d1

Merge pull request go-gorp#230 from umisama/patch-3

ad7cc6c

Fix old description about GORP_TEST_DIALECT in README.md

Update README.md regarding Go supported versions.

1829ef3

Travis build: drop go1.1, add go1.2, go1.3 and go1.4

37e3d43

Merge pull request go-gorp#231 from umisama/patch-4

e66dcda

Fix expand query on NullTime or other structs.

Merge pull request go-gorp#234 from GeertJohan/supported-go-versions

9992d76

Supported go versions

Readme: latest > last, minor > major.

6ac74a0

Merge branch 'patch-1' of https://github.com/sqdk/gorp into patch-1

509244d

Merge remote-tracking branch 'upstream/master' into patch-1

7d4ea60

Conflicts: .travis.yml

Removed unnecessary imports

562843a

Add NullTime in Postgres ToSqlType

6c5ace9

Fix old description about GORP_TEST_DIALECT in README.md

46f15d0

Fix expand query on NullTime or other structs.

a17e1eb

Update README.md regarding Go supported versions.

2c4a968

Travis build: drop go1.1, add go1.2, go1.3 and go1.4

8ee131d

Squash

d3f0a40

Readme: latest > last, minor > major. Removed unnecessary imports Removed unnecessary tests

Merge branch 'patch-1' of https://github.com/sqdk/gorp into patch-1

dcba119

Conflicts: .travis.yml

Merge pull request go-gorp#224 from sqdk/patch-1

aa5e410

Remove automatic mapping of version column (optimistic locking)

Fixed NullTime returns always invalid on sqlite3.

d376e08

umisama force-pushed the develop-patch1 branch from fb1020d to d376e08 Compare February 27, 2015 05:27

GeertJohan pushed a commit that referenced this pull request Mar 1, 2015

Merge pull request #203 from umisama/develop-patch1

1fd7f81

Fixed NullTime returns always invalid on sqlite3.

GeertJohan merged commit 1fd7f81 into go-gorp:develop Mar 1, 2015

umisama mentioned this pull request Mar 3, 2015

Fixed NullTime returns always invalid on sqlite3. #237

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed NullTime returns always invalid on sqlite3. #203

Fixed NullTime returns always invalid on sqlite3. #203

umisama commented Oct 17, 2014

benprew commented Jan 31, 2015

GeertJohan commented Feb 16, 2015

umisama commented Feb 27, 2015

GeertJohan commented Mar 1, 2015

umisama commented Mar 2, 2015

GeertJohan commented Mar 2, 2015

umisama commented Mar 3, 2015

coveralls commented Oct 4, 2016

Fixed NullTime returns always invalid on sqlite3. #203

Fixed NullTime returns always invalid on sqlite3. #203

Conversation

umisama commented Oct 17, 2014

benprew commented Jan 31, 2015

GeertJohan commented Feb 16, 2015

umisama commented Feb 27, 2015

GeertJohan commented Mar 1, 2015

umisama commented Mar 2, 2015

GeertJohan commented Mar 2, 2015

umisama commented Mar 3, 2015

coveralls commented Oct 4, 2016