Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.9.0 #146

Merged
merged 12 commits into from
May 28, 2021
Merged

v3.9.0 #146

merged 12 commits into from
May 28, 2021

Conversation

System-Glitch
Copy link
Member

@System-Glitch System-Glitch commented May 20, 2021

Description

  • Fixed random inconsistencies in validation results when using rules comparing value to other fields.
  • Added RuleDefinition.ComparesFields to specify a rule can compare the field under validation with another field. Custom rules that do so should update their definition to avoid previously mentioned inconsistencies.
  • Fixed a bug causing the shutdown hook listening to SIGINT and SIGTERM to clear itself at server startup.
  • Fixed a bug causing fields inside objects to not be converted by type rules and leaving junk into the input data.
  • Handle dot-separated path for comparison validation rules.

Possible drawbacks

  • Slightly slower boot time, because keys are sorted at startup.
  • Very slightly slower validation

Related issue(s)

List all related issues here:

@System-Glitch System-Glitch added the bug Something isn't working label May 20, 2021
@System-Glitch System-Glitch requested a review from a team May 20, 2021 14:28
@System-Glitch System-Glitch self-assigned this May 20, 2021
@System-Glitch System-Glitch marked this pull request as draft May 20, 2021 14:29
@coveralls
Copy link

coveralls commented May 20, 2021

Pull Request Test Coverage Report for Build 878779079

  • 133 of 133 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 99.035%

Totals Coverage Status
Change from base Build 796157921: 0.008%
Covered Lines: 4206
Relevant Lines: 4247

💛 - Coveralls

@System-Glitch System-Glitch marked this pull request as ready for review May 26, 2021 13:58
@System-Glitch System-Glitch merged commit 32e4b2d into master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants