Clickhouse aggregation #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passes basic tests (queries from carbonapi 0.14.0): * /metrics/find requests (with and without globs) * /render with single metric * /render with globs * /render with several targets
Change URL for http request to include parameters that are now in the body
This handler is used by carbonapi to detect support of carbonapi_v3_pb and get information about backend and it's preferences and supported features.
This fixes request handling when query used timeShift
Felixoid
force-pushed
the
clickhouse_aggregation
branch
3 times, most recently
from
8a759b6
to
48f8f65
Compare
Felixoid
force-pushed
the
clickhouse_aggregation
branch
11 times, most recently
from
8d1fbb3
to
bc654de
Compare
Felixoid
force-pushed
the
clickhouse_aggregation
branch
2 times, most recently
from
5282aae
to
0db4011
Compare
- WIP: implement max-data-points and internal-aggregation clickhouse parameters - Move data fetching into render package - Create Rules.RollupPoints function, use it right after data fetching - Implement locking in alias.Map for concurrent usage - render.FetchDataPoints: universal function to get data points. Use carbonlink, if specified. Make requests in goroutines - prometheus and render: use FetchDataPoints - data: use ReadUvarint from clickhouse package; return data in case of error to have debug info fixup! Moderate data fetching refactoring
- Enabled only when `internal-aggregation` in [clickhouse] is used - Use proper aggregation function in query - Amount of data points is calculated out of maxDataPoints
Felixoid
force-pushed
the
clickhouse_aggregation
branch
from
0db4011
to
8a7b7a4
Compare
This was referenced Oct 1, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR:
see https://github.com/lomik/graphite-clickhouse/wiki/ClickHouse-aggregation-VS-graphite-clickhouse-aggregation
Here the next is done:
Moderate data fetching refactoring
Add optional ClickHouse site points aggregation
internal-aggregationin [clickhouse] is usedBuild: update go metrics
Improve logging and answer 500 on marshalling errors
This PR depends on #85