-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More SEGFAULT safety #62
Conversation
see also: go-gst/go-glib#3 |
I have this commit pinned in my application and I will test it for some time. But as said before, I cannot test all features touched in this PR. Surprisingly in my application this didn't introduce any breaking changes. |
First Feedback on this PR: The following graph shows the audio gain produced by ~40 instances of my application, you can clearly see the anomalies where the segfaults happened. You can also clearly see that the fix worked: I'll keep a look at it, but given the amount of aggregated runtime over this period, I'm pretty happy with it. As I said, this didn't introduce any breaking changes in my app. @danjenkins maybe try to use this branch in one of your applications, to see if anything breaks. |
with the addition of eeb454d I would be happy to merge this. The changes drastically improve stability in my case and do not produce any go:vet issues in go-gst/go-glib anymore Maybe we should merge glib first and pin the dependency to the commit on main? |
I'm good with that - we still haven't done a proper release yet so I think now's a good time to just do it and see! |
merged the go-glib change and used the new go-glib version in this project, merging. |
closes #61
This removes all uses of
uintptr
across the bindings and also fixes a possible GC related SIGSEGV inglib.SetProperty
with go-gst/go-glib#3