-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix windows build, hopefully #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this builds, could you also add the workflow steps to go-glib, please?
Of course - thanks for the reminder |
@RSWilli done and done :) |
I don't personally build on windows. Is the Readme still correct for local building? https://github.com/go-gst/go-gst?tab=readme-ov-file#windows Or were the problems fixed by this PR only GH actions specific? |
ping @danjenkins |
I'm not 100% sure. I think the README needs changed but ultimately we shouldn't be in a position where we tell people to downgrade their versions etc.... I'm going to make a new issue to investigate that. I'm in a similar position, I don't actively develop on windows... I just build on windows. Edit: we already have #50 |
okay I'm going to merge it then, we'll postpone the windows build issues to #50 |
Make Windows builds work. The only way I've been able to make this work so far is to make it downgrade things and add the relevant paths in the relevant places
fixes #64