Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows build, hopefully #72

Merged
merged 2 commits into from
Apr 4, 2024
Merged

fix windows build, hopefully #72

merged 2 commits into from
Apr 4, 2024

Conversation

danjenkins
Copy link
Contributor

@danjenkins danjenkins commented Apr 2, 2024

Make Windows builds work. The only way I've been able to make this work so far is to make it downgrade things and add the relevant paths in the relevant places

fixes #64

@danjenkins danjenkins requested a review from RSWilli April 2, 2024 16:39
Copy link
Member

@RSWilli RSWilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this builds, could you also add the workflow steps to go-glib, please?

.github/workflows/build.yml Outdated Show resolved Hide resolved
@danjenkins
Copy link
Contributor Author

Of course - thanks for the reminder

@danjenkins
Copy link
Contributor Author

@RSWilli done and done :)

@RSWilli
Copy link
Member

RSWilli commented Apr 3, 2024

I don't personally build on windows. Is the Readme still correct for local building? https://github.com/go-gst/go-gst?tab=readme-ov-file#windows Or were the problems fixed by this PR only GH actions specific?

@RSWilli
Copy link
Member

RSWilli commented Apr 4, 2024

ping @danjenkins

@danjenkins
Copy link
Contributor Author

danjenkins commented Apr 4, 2024

I don't personally build on windows. Is the Readme still correct for local building? https://github.com/go-gst/go-gst?tab=readme-ov-file#windows Or were the problems fixed by this PR only GH actions specific?

I'm not 100% sure. I think the README needs changed but ultimately we shouldn't be in a position where we tell people to downgrade their versions etc.... I'm going to make a new issue to investigate that. I'm in a similar position, I don't actively develop on windows... I just build on windows.

Edit: we already have #50

@RSWilli

@RSWilli
Copy link
Member

RSWilli commented Apr 4, 2024

okay I'm going to merge it then, we'll postpone the windows build issues to #50

@RSWilli RSWilli merged commit d3141af into main Apr 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate windows build issues
2 participants