Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groot: implement new rfunc-gen default type name convention #742

Merged
merged 3 commits into from May 29, 2020

Conversation

sbinet
Copy link
Member

@sbinet sbinet commented May 29, 2020

Updates #737.

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #742 into master will increase coverage by 0.02%.
The diff coverage is 92.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
+ Coverage   71.49%   71.52%   +0.02%     
==========================================
  Files         384      384              
  Lines       48912    49079     +167     
==========================================
+ Hits        34972    35104     +132     
- Misses      11684    11719      +35     
  Partials     2256     2256              
Impacted Files Coverage Δ
groot/internal/genroot/genrfunc.go 65.97% <44.92%> (-9.03%) ⬇️
groot/rdict/rdict.go 92.48% <100.00%> (+0.56%) ⬆️
groot/rtree/rfunc/rfunc_bool_gen.go 100.00% <100.00%> (ø)
groot/rtree/rfunc/rfunc_f32_gen.go 100.00% <100.00%> (ø)
groot/rtree/rfunc/rfunc_f64_gen.go 100.00% <100.00%> (ø)
groot/rtree/rfunc/rfunc_f64s_gen.go 100.00% <100.00%> (ø)
groot/rtree/rfunc/rfunc_i32_gen.go 100.00% <100.00%> (ø)
groot/rtree/rfunc/rfunc_i64_gen.go 100.00% <100.00%> (ø)
groot/rtree/rfunc/rfunc_u32_gen.go 100.00% <100.00%> (ø)
groot/rtree/rfunc/rfunc_u64_gen.go 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d1e5f0...020b43e. Read the comment docs.

@sbinet sbinet merged commit 020b43e into go-hep:master May 29, 2020
@sbinet sbinet deleted the issue-737 branch May 29, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant