Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes unreacheable statement #928

Merged
merged 1 commit into from May 5, 2022
Merged

removes unreacheable statement #928

merged 1 commit into from May 5, 2022

Conversation

chavacava
Copy link
Contributor

log.Fatal already returns exit code 1

found with revive rule unreachable-code

found with revive (https://github.com/mgechev/revive) rule unreachable-code
Copy link
Member

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks for the PR.

could you send another CL/commit adding yourself to the AUTHORS and/or CONTRIBUTORS file(s)?
thanks again.

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #928 (abfe1a4) into main (b02724a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #928   +/-   ##
=======================================
  Coverage   73.77%   73.77%           
=======================================
  Files         409      409           
  Lines       48779    48779           
=======================================
  Hits        35986    35986           
  Misses      10510    10510           
  Partials     2283     2283           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b02724a...abfe1a4. Read the comment docs.

@sbinet
Copy link
Member

sbinet commented May 5, 2022

ping?

please send a PR against the go-hep/license repository, adding yourself to the AUTHORS and/or CONTRIBUTORS files, so I can merge this PR in.

thanks again.

@sbinet
Copy link
Member

sbinet commented May 5, 2022

needs go-hep/license#13

@sbinet sbinet merged commit 020835d into go-hep:main May 5, 2022
@sbinet
Copy link
Member

sbinet commented May 5, 2022

thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants