Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: drop Go-1.17 #929

Merged
merged 4 commits into from Apr 4, 2022
Merged

all: drop Go-1.17 #929

merged 4 commits into from Apr 4, 2022

Conversation

sbinet
Copy link
Member

@sbinet sbinet commented Apr 4, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022

Codecov Report

Merging #929 (ccbaeb3) into main (b02724a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #929      +/-   ##
==========================================
- Coverage   73.77%   73.77%   -0.01%     
==========================================
  Files         409      409              
  Lines       48779    48781       +2     
==========================================
  Hits        35986    35986              
- Misses      10510    10511       +1     
- Partials     2283     2284       +1     
Impacted Files Coverage Δ
cmd/podio-gen/generator.go 76.41% <100.00%> (+0.12%) ⬆️
groot/internal/genroot/genrfunc.go 63.30% <100.00%> (ø)
groot/rtree/rvar.go 90.17% <100.00%> (+0.05%) ⬆️
groot/rtree/wvar.go 94.36% <100.00%> (ø)
version.go 90.47% <0.00%> (-9.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b02724a...ccbaeb3. Read the comment docs.

namely:
 - strings.Title -> cases.Title
 - go/types.NewSignature -> go/types.NewSignatureType
@sbinet sbinet merged commit ccbaeb3 into go-hep:main Apr 4, 2022
@sbinet sbinet deleted the go-generics branch April 4, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants