Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include fragment identifier when matching. #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jancona
Copy link
Contributor

@jancona jancona commented Jul 7, 2017

I ran into problems with fragment ids causing URLs not to match and it seemed odd to match on them, given the the server doesn't normally see them.

@albrow
Copy link
Contributor

albrow commented Dec 14, 2017

@jancona can you provide some more context on the problems you were running into? go-humble/router is designed to fallback to using fragment ids whenever history.pushState is not supported. I'm hesitant to accept this change without understanding why it is necessary and how it might affect behavior in older browsers that do not support history.pushState.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants