parser: support unmashalling to all basic type pointers #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
unknwon
changed the title
This was referenced Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem should be fixed?
Unmashalling to a pointer field facilitates distinguishing between a key being undefined and being defined with the type's zero value. This is useful for cases where an application defines a default value, which is not the type's zero value and the config should be able to set the field value to the type's zero value.
This feature was already supported for
*bool- I have extended the capability to all of the supported basic types.Have you added test cases to catch the problem?
Yes, I have extended the existing test to cover all of the new types.