Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.1.1 contains breaking changes #76

Closed
emersion opened this issue Mar 13, 2020 · 5 comments
Closed

v3.1.1 contains breaking changes #76

emersion opened this issue Mar 13, 2020 · 5 comments

Comments

@emersion
Copy link
Contributor

f252a88 is a breaking change. This breaks builds.

@belak
Copy link
Member

belak commented Mar 13, 2020

I’m unsure what the best path forward would be here. As, unlike most other package systems, you cannot revoke versions. Optimally I think I would have revoked 3.0.0 as it had numerics I don’t want to support in there. I’ll have to take a closer look when I’m at a computer.

@belak
Copy link
Member

belak commented Mar 13, 2020

I’d be fine releasing a new major version, but then I’d want to fix the issue with hanging and potentially change the method signature of a few functions as well.

@emersion
Copy link
Contributor Author

I think a reasonable path forward would be to un-do the breaking changes with a bugfix version, then prepare a new major version with all the breaking changes. This would allow existing users to upgrade safely.

@belak
Copy link
Member

belak commented Mar 13, 2020

I've added back sections for obsolete RFC1459 and RFC2812 commands. I believe these are the 16 that were removed in the previous commit. I've tagged it v3.1.2. Next breaking change will probably be fixes for the Client and will include a major version bump.

Thanks for mentioning this!

@belak belak closed this as completed Mar 13, 2020
@emersion
Copy link
Contributor Author

Thanks!

emersion added a commit to emersion/soju that referenced this issue Mar 18, 2020
go-irc v3.1.1 contains a breaking change.

References: go-irc/irc#76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants