Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop TagValue #83

Closed
emersion opened this issue Jan 22, 2021 · 2 comments
Closed

Drop TagValue #83

emersion opened this issue Jan 22, 2021 · 2 comments

Comments

@emersion
Copy link
Contributor

Would you consider dropping the TagValue type so that the Tags type can just be map[string]string? That would avoid unnecessary conversions between TagValue and string when accessing or updating tags.
@belak
Copy link
Member

belak commented Jan 22, 2021

Yeah, this seems like a reasonable change - thankfully I haven't released v4 yet, so I can still make these tweaks

belak added a commit that referenced this issue Jan 22, 2021
@belak
Remove TagValue and Tags.GetTag
b8a23e9 
Fixes #83
Fixes #84
@belak belak mentioned this issue Jan 22, 2021
Merged
belak added a commit that referenced this issue Jan 22, 2021
@belak
Remove TagValue and Tags.GetTag
7ba1a18 
Fixes #83
Fixes #84
@belak
Copy link
Member

belak commented Jan 22, 2021

Fixed in 7ba1a18. Thanks for the suggestion!

@belak belak closed this as completed Jan 22, 2021
belak added a commit that referenced this issue Sep 11, 2022
@belak
Remove TagValue and Tags.GetTag
2d0e061 
Fixes #83
Fixes #84
belak added a commit that referenced this issue Sep 11, 2022
@belak
Remove TagValue and Tags.GetTag
a8fb3a2 
Fixes #83
Fixes #84
belak added a commit that referenced this issue Sep 11, 2022
@belak
Remove TagValue and Tags.GetTag
7f9d501 
Fixes #83
Fixes #84
belak added a commit that referenced this issue Sep 11, 2022
@belak
Remove TagValue and Tags.GetTag
21801e7 
Fixes #83
Fixes #84
belak added a commit that referenced this issue Sep 11, 2022
@belak
Remove TagValue and Tags.GetTag
cc3f3f3 
Fixes #83
Fixes #84
belak added a commit that referenced this issue Sep 11, 2022
@belak
Remove TagValue and Tags.GetTag
902eb66 
Fixes #83
Fixes #84
belak added a commit that referenced this issue Sep 11, 2022
@belak
Remove TagValue and Tags.GetTag
9057958 
Fixes #83
Fixes #84
belak added a commit that referenced this issue Sep 11, 2022
@belak
Remove TagValue and Tags.GetTag
1638526 
Fixes #83
Fixes #84
belak added a commit that referenced this issue Sep 11, 2022
@belak
Remove TagValue and Tags.GetTag
557389f 
Fixes #83
Fixes #84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@belak @emersion