Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export BinaryOperator function #339

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

kblomster
Copy link
Contributor

This PR exports a BinaryOperator function that is similar in spirit to jet.Func, but for custom/unsupported operators rather than for functions. See #338

This is kind of a proof-of-concept PR; maybe this should have tests? It should probably have docs as well.

Maybe there should also be a UnaryOperator and a TernaryOperator but at least from my perspective I don't foresee a huge need for those.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.39%. Comparing base (1fd423b) to head (1d31062).

Files Patch % Lines
internal/jet/operators.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   90.42%   90.39%   -0.03%     
==========================================
  Files         125      125              
  Lines        7434     7436       +2     
==========================================
  Hits         6722     6722              
- Misses        552      554       +2     
  Partials      160      160              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@go-jet
Copy link
Owner

go-jet commented Mar 28, 2024

LGTM. 👍

@go-jet go-jet merged commit b13f6ab into go-jet:master Mar 28, 2024
3 checks passed
@kblomster kblomster deleted the expose-binary-operator branch April 2, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants