Bot should not handle messages originating from itself

[jfchevrette]

This attempts to fix #5.

The approach is a bit naive but it seems to work in my own testing as well as the included test cases

This adds a check that skips message event handling if the message came from the bot user.

I cannot think of a reason the bot would want to handle it's own messages.

[golangcibot]

122-147 lines are duplicate of adapter_test.go:66-91 (from dupl)

[fgrosse]

At first it was not clear to me either how the two tests differ until I realized its really only the channel names.
I think the duplication can be removed and the test can be clarified like this:

func TestAdapter_IgnoreOwnMessages(t *testing.T) {
	cases := map[string]struct{ Channel string }{
		"channel message": {"C1H9RESGL"}, // map test case name to channel ID
		"direct message":  {"D023BB3L2"}, // direct slack channels start with a "D"
	}

	for name, c := range cases {
		t.Run(name, func(t *testing.T) {
			brain := joetest.NewBrain(t)
			a, _ := newTestAdapter(t)

			done := make(chan bool)
			go func() {
				a.handleSlackEvents(brain.Brain)
				done <- true
			}()

			evt := &slack.MessageEvent{
				Msg: slack.Msg{
					Text:    "Hello world",
					Channel: c.Channel,
					User:    a.userID,
				},
			}

			a.events <- slack.RTMEvent{Data: evt}

			close(a.events)
			<-done
			brain.Finish()

			assert.Empty(t, brain.RecordedEvents())
		})
	}
}

Note that I also used a.userID in the event instead of the magic "42" because otherwise it requires the reader of the test to know that this ID is actually the test adapters ID which is set in a different function.

[jfchevrette]

I am not sure how to fix the dupl errors. Should I change the function names so they are less alike?

[fgrosse]

Thank you for your contribution :)

[fgrosse]

At first it was not clear to me either how the two tests differ until I realized its really only the channel names.
I think the duplication can be removed and the test can be clarified like this:

func TestAdapter_IgnoreOwnMessages(t *testing.T) {
	cases := map[string]struct{ Channel string }{
		"channel message": {"C1H9RESGL"}, // map test case name to channel ID
		"direct message":  {"D023BB3L2"}, // direct slack channels start with a "D"
	}

	for name, c := range cases {
		t.Run(name, func(t *testing.T) {
			brain := joetest.NewBrain(t)
			a, _ := newTestAdapter(t)

			done := make(chan bool)
			go func() {
				a.handleSlackEvents(brain.Brain)
				done <- true
			}()

			evt := &slack.MessageEvent{
				Msg: slack.Msg{
					Text:    "Hello world",
					Channel: c.Channel,
					User:    a.userID,
				},
			}

			a.events <- slack.RTMEvent{Data: evt}

			close(a.events)
			<-done
			brain.Finish()

			assert.Empty(t, brain.RecordedEvents())
		})
	}
}

Note that I also used a.userID in the event instead of the magic "42" because otherwise it requires the reader of the test to know that this ID is actually the test adapters ID which is set in a different function.

[fgrosse]

Oh, and can you also please update the CHANGELOG.md?

E.g. like this:

diff --git a/CHANGELOG.md b/CHANGELOG.md
index ce3d71d..75f2766 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,7 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
-Nothing so far
+- Fix issue [Bot is handling messages coming from itself #5](https://github.com/go-joe/slack-adapter/issues/5)
 
 ## [v0.6.0] - 2019-04-19
 - Update to joe v0.7.0