Add support for Microsoft Key Vault HSM key types #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HSM protected keys on Microsoft Key Vault have the suffix "-HSM" in the kty property. This commit adds support for unmarshaling those keys. See https://learn.microsoft.com/en-us/azure/key-vault/keys/about-keys#hsm-protected-keys
This was referenced Jan 11, 2023
|
@csstaub is me again, from square/go-jose#224 and square/go-jose#190 Do you think that this PR makes sense in go-jose? Microsoft is not very kind with keeping standards ;) |
|
I'm not really sure if we should support this. On the one hand, it doesn't seem unreasonable, but it's also completely nonstandard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
HSM-protected keys on Microsoft Key Vault have the suffix "-HSM" in the
ktyproperty. This commit adds support for unmarshaling those keys.See https://learn.microsoft.com/en-us/azure/key-vault/keys/about-keys#hsm-protected-keys