Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for WebSockets in Server interface #1092

Closed
wicknicks opened this issue May 25, 2021 · 0 comments · Fixed by #1212
Closed

Support for WebSockets in Server interface #1092

wicknicks opened this issue May 25, 2021 · 0 comments · Fixed by #1212

Comments

@wicknicks
Copy link

net/http added support for websockets in v1.12 (discussion). The change however requires applications to use an additional interface (Hijacker) to 'hijack' the connection and access the I/O channels. When applications use go-kit, the http.ResponseWriter is replaced by an interceptingWriter here: https://github.com/go-kit/kit/blob/v0.10.0/transport/http/server.go#L99. This only embeds the original http.ResponseWriter. To open up support for websockets, we needs to embed the Hijacker interface as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants