Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codahale/hdrhistogram repo url has been transferred under the github HdrHstogram umbrella #1176

Closed
filipecosta90 opened this issue Aug 16, 2021 · 3 comments · Fixed by #1177
Milestone

Comments

@filipecosta90
Copy link

Problem

The codahale/hdrhistogram repo has been transferred under the github HdrHstogram umbrella with the help from the original author in Sept 2020 (new repo url https://github.com/HdrHistogram/hdrhistogram-go). The main reasons are to group all implementations under the same roof and to provide more active contribution from the community as the original repository was archived several years ago.

The dependency URL should be modified to point to the new repository URL. The tag "v0.9.0" was applied at the point of transfer and will reflect the exact code that was frozen in the original repository.

If you are using Go modules, you can update to the exact point of transfer using the @v0.9.0 tag in your go get command.

go mod edit -replace github.com/codahale/hdrhistogram=github.com/HdrHistogram/hdrhistogram-go@v0.9.0

Performance Improvements

From the point of transfer, up until now (mon 16 aug 2021), we've released 3 versions that aim support the standard HdrHistogram serialization/exposition formats, and deeply improve READ performance.
We recommend to update to the latest version.

@sagikazarmark
Copy link
Contributor

Thanks! This is already tracked here: #1127

@peterbourgon
Copy link
Member

Any reason not to change the reference in master now?

Salty kvetching below:

go mod edit -replace ...

God, what a disaster 🤦

@filipecosta90
Copy link
Author

Any reason not to change the reference in master now?

No reason -- all updates/changes are retrocompatible.
The latest stable version is https://github.com/HdrHistogram/hdrhistogram-go/releases/tag/v1.1.0 .
On master we currently have some more READ performance inprovements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants