Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load balancer to addsvc client #89

Closed
peterbourgon opened this issue Aug 1, 2015 · 4 comments
Closed

Add load balancer to addsvc client #89

peterbourgon opened this issue Aug 1, 2015 · 4 comments

Comments

@peterbourgon
Copy link
Member

As an example of how to use it.

@jupp0r
Copy link
Contributor

jupp0r commented Mar 15, 2016

Would you add this to all transport-specific clients separately or refactor them to use a common endpoint abstraction with load balancing injected as middleware?

@peterbourgon
Copy link
Member Author

Good question! I think you'd want to keep the transport-specific clients as separate packages, and wire in the same loadbalancing middleware to each. I think you can do that without significant code duplication. The important thing is to make it easy to use from a consumer perspective: you want to make it a single constructor, ideally from a single package (per transport), and not have to stitch multiple things together in the client-side code. Make sense?

@jupp0r
Copy link
Contributor

jupp0r commented Mar 16, 2016

Yes. This would probably be easier with #217 implemented.

@jupp0r
Copy link
Contributor

jupp0r commented Apr 7, 2016

I think this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants