Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples/addsvc: use transport/grpc #217

Closed
peterbourgon opened this issue Mar 14, 2016 · 2 comments
Closed

examples/addsvc: use transport/grpc #217

peterbourgon opened this issue Mar 14, 2016 · 2 comments
Labels
help wanted newbie friendly

Comments

@peterbourgon
Copy link
Member

Right now, the example just does a dumb binding to gRPC directly. Change it to use transport/grpc.
This was referenced Mar 16, 2016
Closed
Merged
Merged
jupp0r added a commit to jupp0r/kit that referenced this issue Mar 21, 2016
@jupp0r
Use grpc transport in addsvc example client
323488f 
This change replaces the custom grpc bindings in the addsvc example with
usage of the transport.grcp client. Change 1/2 to resolve issue go-kit#217.
@jupp0r
Copy link
Contributor

jupp0r commented Mar 29, 2016

I think this can be closed.

@peterbourgon
Copy link
Member Author

Righto.

guycook pushed a commit to codelingo/kit that referenced this issue Oct 12, 2016
@jupp0r
Use grpc transport in addsvc example client
51284cd 
This change replaces the custom grpc bindings in the addsvc example with
usage of the transport.grcp client. Change 1/2 to resolve issue go-kit#217.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted newbie friendly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterbourgon @jupp0r