Minimal Binary Annotations Support #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taion809
changed the title
| encodedSpan := span.Encode() | ||
| annotations := encodedSpan.GetBinaryAnnotations() | ||
|
|
||
| if annotations[0].Key != key { |
There was a problem hiding this comment.
Can we have a len check too, perhaps?
|
Thank you! With this minor changes, LGTM. The Travis failure is unrelated, I will investigate that separately. |
peterbourgon
added a commit
that referenced
this pull request
Feb 15, 2016
Minimal Binary Annotations Support
|
Thank you for the contribution! |
guycook
pushed a commit
to codelingo/kit
that referenced
this pull request
Oct 12, 2016
Minimal Binary Annotations Support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull requests adds minimal support for Binary Annotations.
The following api is now exposed:
AnnotateBinary(key string, value []byte)corresponding toAnnotationType_BYTESAnnotateString(key, value string)corresponding toAnnotationType_STRING